thanos-io / thanos

Use Partial Response should be enabled by default

Thanos Issue Summary: Use Partial Response Should Be Enabled By Default

Issue Creator: SanthoshiMekala Date Created: April 12, 2023 Thanos Version: 0.29.0 Prometheus Version: 2.40.0

Background

The request is to enable the “Use Partial Response” feature in the Thanos query UI by default. The current implementation does not automatically reflect changes made to the --query.partial-response flag in the UI or during queries.

Current State

  • SanthoshiMekala attempted to configure the --query.partial-response flag but found it is not propagated to the UI.
  • Contributors acknowledged that there is no straightforward method to enable this by default, but flagged propagation to the UI as a possible solution.
  • The UI currently accesses flags through api/v1/status/flag, suggesting that further development is required to link this functionality directly to the panel component.

Contributions and Discussion

  • There is a consensus among the contributors that modifying the existing infrastructure to facilitate flag propagation will not only resolve this specific issue but could also standardize flag management across all UI components.
  • Acceptance criteria proposed by SanthoshiMekala include making UI flags configurable through the Thanos query container configuration.

Recent Developments

  • Contributor mak2002 expressed interest in the issue and successfully configured the default behavior of the “Use Partial Response” option by passing the flag’s value to the panel component. However, they encountered an issue where the toggled state resets to the default upon page re-render.
  • They inquired about persisting user adjustments, such as using local storage, and suggested implementing support for additional UI flags (e.g., Enable Autocompletion, Enable Highlighting).

Next Steps

  • A pull request has been raised by Vanshikav123 to address this issue.
  • Review and testing of the pull request are needed to ensure that the implementation meets the acceptance criteria and functions correctly within the Thanos query UI.

This issue encapsulates both a specific requirement for user experience enhancement and broader implications for consistency in UI flag management within the Thanos project.