Discover Good First Issues for fluxcd/flux2
-
CodeCommit: Failed to retrieve list of SSH authentication methods Created: 2022-01-24T15:26:05Z
Describe the bug
https://fluxcd.io/docs/use-cases/aws-codecommit/
Flux Create Source:
Failed to retrieve list of SSH authentication methods
► applying secret with repository credentials ✔ authentication configured ► applying GitRepository source ✔ GitRepository source updated ◎ waiting for GitRepository source reconciliation ✗ unable to clone: Failed to retrieve list of SSH authentication methods: Failed getting response
Based on some research it has to do with libssh2 upgrade changed the format:
libgit2/pygit2#1013 (comment)
It seems in order for this to work with CodeCommit the -M PEM flag would be necessary when generating the deploy key?
Steps to reproduce
Flux Create Source:
► applying secret with repository credentials ✔ authentication configured ► applying GitRepository source ✔ GitRepository source updated ◎ waiting for GitRepository source reconciliation ✗ unable to clone: Failed to retrieve list of SSH authentication methods: Failed getting response
Based on some research it has to do with libssh2 upgrade changed the format:
libgit2/pygit2#1013 (comment)
Expected behavior
It seems in order for this to work with CodeCommit the
-m PEMflag would be necessary when generating the deploy key?Need a
--ssh-key-formatparameter in order to specify PEM.Screenshots and recordings
No response
OS / Distro
macOS 12.1
Flux version
v0.25.3
Flux check
❯ flux check ► checking prerequisites ✔ Kubernetes 1.21.5-eks-bc4871b >=1.19.0-0 ► checking controllers ✔ helm-controller: deployment ready ► ghcr.io/fluxcd/helm-controller:v0.15.0 ✔ kustomize-controller: deployment ready ► ghcr.io/fluxcd/kustomize-controller:v0.19.1 ✔ notification-controller: deployment ready ► ghcr.io/fluxcd/notification-controller:v0.20.1 ✔ source-controller: deployment ready ► ghcr.io/fluxcd/source-controller:v0.20.1 ✔ all checks passed
Git provider
AWS CodeCommit
Container Registry provider
No response
Additional context
No response
Code of Conduct
- I agree to follow this project’s Code of Conduct
Comments: 5
Unassigned -
`flux create source git` with `--password` fails to create secret Created: 2023-05-17T16:57:35Z
Describe the bug
When using flux cli, I expect to be able to use Azure DevOps personal access token (PAT). But the command “flux create source git” delete the Kubernetes secret when the username is not specified. If we modify the secret manually, removing the username, everything still working.
Steps to reproduce
- install flux in a Kubernetes cluster
- run command line “flux create source git password=’${my-PAT}’ –url=’${my-git-repo}’ name”
- flux gitreposity created but authentication fails
- secret with the same as the gitrepository
Expected behavior
A kubernetes secret shoul be created without username but with password field.
Screenshots and recordings
No response
OS / Distro
Ubuntu 20.04
Flux version
v0.34.0
Flux check
► checking prerequisites ✗ flux 0.34.0 <2.0.0-rc.3 (new version is available, please upgrade) ✔ Kubernetes 1.23.7 >=1.20.6-0 ✔ helm-controller: deployment ready ✔ image-automation-controller: deployment ready ✔ image-reflector-controller: deployment ready ✔ kustomize-controller: deployment ready ✔ notification-controller: deployment ready ✔ source-controller: deployment ready ✔ alerts.notification.toolkit.fluxcd.io/v1beta1 ✔ buckets.source.toolkit.fluxcd.io/v1beta2 ✔ gitrepositories.source.toolkit.fluxcd.io/v1beta2 ✔ helmcharts.source.toolkit.fluxcd.io/v1beta2 ✔ helmreleases.helm.toolkit.fluxcd.io/v2beta1 ✔ helmrepositories.source.toolkit.fluxcd.io/v1beta2 ✔ imagepolicies.image.toolkit.fluxcd.io/v1beta1 ✔ imagerepositories.image.toolkit.fluxcd.io/v1beta1 ✔ imageupdateautomations.image.toolkit.fluxcd.io/v1beta1 ✔ kustomizations.kustomize.toolkit.fluxcd.io/v1beta2 ✔ providers.notification.toolkit.fluxcd.io/v1beta1 ✔ receivers.notification.toolkit.fluxcd.io/v1beta1 ✔ all checks passed
Git provider
Azure DevOps
Container Registry provider
No response
Additional context
No response
Code of Conduct
- I agree to follow this project’s Code of Conduct
Comments: 7
-
Review and enforce CRD Validation Created: 2022-08-17T10:51:16Z
In the run-up to maturing flux APIs, we should review all CRD validation and ensure that they align with expected input.
Controllers:
source-controller
kustomize-controller
helm-controller
notification-controller
image-reflector-controller
image-automation-controller
Additional points to consider:
Use kubebuilder validation and add tests, as per https://github.com/fluxcd/helm-controller/pull/520.
.Specfields should be marked as required across all CRDs.String fields should have a max length and pattern defined (when possible).
We should use reference types from pkg, and also improve its current validation: https://github.com/fluxcd/pkg/blob/main/apis/meta/reference_types.go
Comments: 5
