# Unrestricted Upload of File with Dangerous Type (CWE-434)

The product allows the upload of files without properly validating the file type, which can lead to execution of malicious code.

**Stack:** Go

- Prevalence: High Frequently exploited
- Impact: High 3 high-severity rules
- Prevention: Documented 3 fix examples

**OWASP:** Broken Access Control (A01:2021-Broken Access Control) - #1

## Description

When users can upload files without restriction, attackers may upload executable files, scripts, or other dangerous content that can be executed by the server or other users.

## Prevention

Prevention strategies for Unrestricted File Upload based on 1 Shoulder detection rules.

### Go

Validate file type, enforce size limits, and use generated filenames for uploads

## Warning Signs

- [HIGH] File upload lacks proper validation

## Consequences

- Execute Unauthorized Code
- Read Application Data
- Modify Application Data

## Mitigations

- Validate file types on the server side, not just by extension
- Store uploaded files outside the web root
- Use allowlist for permitted file types
- Rename uploaded files to prevent execution

## Detection

- Total rules: 3
- Languages: go, javascript, typescript, python

## Rules by Language

### Go (1 rules)

- **Unsafe File Upload** [HIGH]: File upload processed without type validation, size limits, or filename sanitization.
  - Remediation: Validate file type, limit size, and use a generated filename.

```go
r.Body = http.MaxBytesReader(w, r.Body, 10*1024*1024) // 10 MB limit
file, header, _ := r.FormFile("file")

ext := filepath.Ext(header.Filename)
safeFilename := uuid.New().String() + ext
dst, _ := os.Create(filepath.Join("/var/uploads", safeFilename))
io.Copy(dst, file)
```

Learn more: https://shoulder.dev/learn/go/cwe-434/unsafe-file-upload