ベータ Shoulder はベータ版です — 結果が誤っている場合があります。皆さまのフィードバックが次に修正する内容を決定します。 フィードバックを送る
🚫

Improper Access Control

🛡️ 4 件のルールが検出します

Improper Access Control

The product does not restrict or incorrectly restricts access to a resource from an unauthorized actor.

Access control involves determining which subjects can access which objects. When access control is implemented incorrectly, it can lead to unauthorized access to sensitive data or functionality.

普及度
頻繁に悪用される
影響度
ハイ
3 件の重大度ハイのルール
予防
文書化済み
4 件の修正例
2 予防
2 予防

この脆弱性の修正方法

4 件の Shoulder 検出ルールに基づく Improper Access Control の予防策。

LLM Insecure Plugin Design HIGH

Validate tool inputs against strict schemas and use an allowlist for permitted tools

+18 -2 go
- func handleToolCall(toolCall ToolCall) (interface{}, error) {
-     return tools[toolCall.Name](toolCall.Arguments)
+ var toolRegistry = map[string]ToolConfig{
+     "search":  {Handler: searchHandler, Validator: validateSearch, Permission: "read"},
+     "weather": {Handler: weatherHandler, Validator: validateWeather, Permission: "read"},
+ }
+ 
+ func handleToolCall(userPerms map[string]bool, toolCall ToolCall) (interface{}, error) {
+     config, ok := toolRegistry[toolCall.Name]
+     if !ok {
+         return nil, fmt.Errorf("unknown tool: %s", toolCall.Name)
+     }
+     if !userPerms[config.Permission] {
+         return nil, fmt.Errorf("permission denied for tool: %s", toolCall.Name)
+     }
+     args, err := config.Validator(toolCall.Arguments)
+     if err != nil {
+         return nil, fmt.Errorf("invalid arguments: %w", err)
+     }
+     return config.Handler(args)
  }
  
LLM Insecure Plugin Design HIGH

Validate tool inputs against schemas and use allowlists for permitted tools

+10 -3 javascript
- for (const toolCall of response.tool_calls) {
-   const fn = tools[toolCall.function.name];
-   const result = await fn(JSON.parse(toolCall.function.arguments));
+ const allowedTools = new Set(['search', 'calculate', 'getWeather']);
+ 
+ for (const toolCall of response.tool_calls) {
+   if (!allowedTools.has(toolCall.function.name)) {
+     throw new Error('Unknown tool');
+   }
+   const validate = ajv.compile(toolSchemas[toolCall.function.name]);
+   const args = JSON.parse(toolCall.function.arguments);
+   if (!validate(args)) throw new Error('Invalid arguments');
+   await tools[toolCall.function.name](args);
  }
  
Missing Network Policy MEDIUM

Define NetworkPolicy resources to restrict pod-to-pod traffic and enforce network segmentation

+17 -11 yaml
- apiVersion: apps/v1
- kind: Deployment
- metadata:
-   name: web
- spec:
-   replicas: 3
-   template:
-     spec:
-       containers:
-       - name: web
-         image: nginx:1.25
+ apiVersion: networking.k8s.io/v1
+ kind: NetworkPolicy
+ metadata:
+   name: web-policy
+ spec:
+   podSelector:
+     matchLabels:
+       app: web
+   policyTypes:
+   - Ingress
+   ingress:
+   - from:
+     - podSelector:
+         matchLabels:
+           role: frontend
+     ports:
+     - port: 80
  
LLM Insecure Plugin Design HIGH

Use Pydantic for tool input validation and maintain a strict allowlist for permitted tools

+14 -4 python
- def handle_tool_call(tool_call):
-     name = tool_call.function.name
-     args = json.loads(tool_call.function.arguments)
-     return tools[name](args)
+ from pydantic import BaseModel, Field
+ 
+ class SearchArgs(BaseModel):
+     query: str = Field(max_length=100, pattern=r'^[a-zA-Z0-9\s]+$')
+ 
+ ALLOWED_TOOLS = {'search_products': SearchArgs, 'get_weather': WeatherArgs}
+ 
+ def handle_tool_call(tool_call):
+     name = tool_call.function.name
+     if name not in ALLOWED_TOOLS:
+         raise ValueError(f'Unknown tool: {name}')
+     schema = ALLOWED_TOOLS[name]
+     args = schema.parse_raw(tool_call.function.arguments)
+     return handlers[name](args)
  
3 検出
3 検出

コードの脆弱性を見つける

Shoulderを使用してコードのImproper Access Controlパターンをスキャンしましょう。 4 ルール.

ターミナル
# Scan with Shoulder CLI
npx @shoulderdev/cli trust --cwe=284

# Or scan entire project
npx @shoulderdev/cli trust .

検出ルール (4)

4 警告サイン
4 警告サイン

コードレビューで注目すべき点

これらのパターンはImproper Access Controlの潜在的な脆弱性を示しています。コードレビューとセキュリティ監査中に探してください。

🟠
Insecure plugin implementation: ... go-llm-insecure-plugin
🟠
insecure plugin/function calling implementations in AI/LLM systems without proper validation go-llm-insecure-plugin
🟡
Workload has no NetworkPolicy for network segmentation kubernetes-missing-network-policy
🟡
Kubernetes deployments without associated NetworkPolicy resources kubernetes-missing-network-policy
🔍

コードベースをスキャン: Improper Access Control

Shoulder CLI はコードベース全体から脆弱なパターンを見つけます。